@ExtremelySunnyYK
Do you feel that this code is tested sufficiently when isolated in this repo? Or are we still depending on integration tests in the core repo for complete coverage?

The tests will be on chain specific folder. For instance EVM will have their own test for evm specific implementation, and Non-Evm will have their own test on their chain specific folder.

What do you mean by 'folder'? We will at least need module separation to prevent the imports from polluting core, and the current policy is to avoid all chain-specific imports in this repo.

The tests will be on chain specific folder. For instance EVM will have their own test for evm specific implementation, and Non-Evm will have their own test on their chain specific folder.

What do you mean by 'folder'? We will at least need module separation to prevent the imports from polluting core, and the current policy is to avoid all chain-specific imports in this repo.

@jmank88 sorry for the lack of clarity. By folder I meant chain specific repository.

For instance test for evm headtracker will be on chainlink-core, and test for Solana will be on chainlink-solana

Will update the PR description for clarity.

@ExtremelySunnyYK
Do you feel that this code is tested sufficiently when isolated in this repo? Or are we still depending on integration tests in the core repo for complete coverage?

Thanks for bringing this up @jmank88 . We will still be having to depend on integration tests in the core / chainlink-<chain> repository for integration test for coverage.

Curious if there might be a better approach?

@aalu1418 has also suggested how we can make use of GitHub automated PR in the meantime before completely moving from core/common to chainlink-relay.
This helps to keep chainlink-relay updated of changes in core so that they remain the same.

Tentatively blocking to asses whether we need to wait to be sure that CI is in a good place (tests/linter/sonar/etc.) before merging. Feel free to dismiss this if CI looks healthy and comprehensive, or if the code is literally copied without changes.
cc @chudilka1

The code is copied without changes. However I will be letting this PR sit for a while for discussion with @prashantkumar1982 and @aalu1418 on the best path for dependency and testing moving forward as well. Since this is the first generalisation part to be moved over, it might highlight some issues.

@ExtremelySunnyYK
Do you feel that this code is tested sufficiently when isolated in this repo? Or are we still depending on integration tests in the core repo for complete coverage?

Thanks for bringing this up @jmank88 . We will still be having to depend on integration tests in the core / chainlink-<chain> repository for integration test for coverage.

Curious if there might be a better approach?

Ideally all generic code would have some dummy concrete test instances to fully cover everything. If we are going to have a bunch of related types using similar sets of generic type parameters in this repo, then it may make sense to have an internal test package that exports shared dummy types to use everywhere. This might naturally start to look like a simplified reference implementation too, which could be leveraged for docs.